Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trim package imports #15

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

trim package imports #15

wants to merge 7 commits into from
+0 −45

Conversation

nkraetzschmar
Copy link
Contributor

throw out all packages from the import set that do not match any entry in a pkg.include file in gardenlinux

Warning

This may break non gardenlinux distros using our repo (e.g. gardenlinux-ccloud)
DO NOT merge till this is evaluated!

@nkraetzschmar
experiment: trim package-imports
21b10ed 
throw out all packages from the import set that do not match any entry in a pkg.include file in gardenlinux
@nkraetzschmar
re-add patchelf
3e11ad4
@nkraetzschmar
re-add vhost qemu packages
7a89cff
@nkraetzschmar
re-add vhost qemu packages
18c40ed
@nkraetzschmar
re-add vhost qemu packages
fab43c8
@nkraetzschmar
Copy link
Contributor Author 

cat $(find gardenlinux/gardenlinux/features -name pkg.include) | grep -v '^[$#]' | sort -u > used_pkgs
cat gardenlinux/repo/package-imports | grep -v '^[$#]' > imported_pkgs
join -v 1 imported_pkgs used_pkgs > pkg_trim
cat pkg_trim | while read pkg; do gsed -i "/^$pkg$/d" package-imports; done

@nkraetzschmar nkraetzschmar mentioned this pull request Jul 26, 2024
Open
4 tasks
@5kt
Copy link
Contributor

5kt commented Jul 31, 2024

Please keep in mind that some included packages might be needed, but are not included anywhere in the GL features.
They are used, for example, in gardenlinux-ccloud. One example would be sssd.

Vincinator
Vincinator reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@Vincinator Vincinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

work in progress, I will continue with this

package-imports
@@ -6,79 +6,48 @@ apparmor
apt-transport-https
arptables
auditd
awscli
azure-vm-utils
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used by features/azure/pkg.include

package-imports
bsdextrautils
btrfs-progs
bubblewrap
build-essential
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used by Nvidia installer test container https://github.com/gardenlinux/gardenlinux-nvidia-installer/blob/5708d7e5a7b5d3642465f958e577ee8f0ceaea71/test.Dockerfile#L7

not sure if we need this test.Dockerfile

package-imports
ca-certificates
ceph
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should keep this

package-imports
dosfstools
dracut
dracut-live
dracut-network
dwarves
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to have a driver build container with the typical build dependencies installed.

Why not some debian container? I would like to install the correct kernel headers for my target Garden Linux (kernel) version.

package-imports
ebtables
efibootmgr
efi-shell-aa64
efi-shell-x64
efitools
ethtool
fatresize
flex
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for driver build container

package-imports
ebtables
efibootmgr
efi-shell-aa64
efi-shell-x64
efitools
ethtool
fatresize
flex
gcc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for driver build container

package-imports
lz4
lzip
lzop
make
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for driver build container

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vincinator Vincinator Vincinator left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkraetzschmar @5kt @Vincinator